architecture.rst: add aw-server-rust, misc. cleanup#160
Open
mrienstra wants to merge 2 commits intoActivityWatch:masterfrom
Open
architecture.rst: add aw-server-rust, misc. cleanup#160mrienstra wants to merge 2 commits intoActivityWatch:masterfrom
architecture.rst: add aw-server-rust, misc. cleanup#160mrienstra wants to merge 2 commits intoActivityWatch:masterfrom
Conversation
Default is `#e74c3c` which reads like "error", changed to a dark orange which seems more neutral, but still "sticks out" enough for skimming purposes.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 00baacc in 1 minute and 32 seconds. Click for details.
- Reviewed
102lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/_static/css/custom.css:18
- Draft comment:
Ensure the chosen inline code color (#a34400) meets accessibility contrast standards across themes. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
2. src/architecture.rst:30
- Draft comment:
Typo: Replace "it's" with "its" and "sent" with "send" for correct grammar. - Reason this comment was not posted:
Comment was on unchanged code.
3. src/architecture.rst:30
- Draft comment:
Typographical issues on this line: - "it's own" should be "its own" as the possessive form is required here. - "sent the data off" might need to be "send the data off" to match the intended present tense. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_QGXVkcxjjM5jkhqN
You can customize 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
architecture.rst:aw-server-rustaw-analysisseems to have been renamed toaw-researchcustom.css: make inline<code>look less alarming#e74c3cwhich reads like "error", changed to a dark orange which seems more neutral, but still "sticks out" enough for skimming purposes.Important
Updates
architecture.rstto includeaw-server-rust, clarify client roles, renameaw-analysistoaw-research, and modifiescustom.cssfor better inline code readability.architecture.rstUpdates:aw-server-rustto server implementations.aw-analysistoaw-research.custom.cssChanges:<code>color from#e74c3cto#a34400for a less alarming appearance.This description was created by
for 00baacc. You can customize this summary. It will automatically update as commits are pushed.